server, statistics: support dump history stats #10291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10291 +/- ##
================================================
- Coverage 77.3234% 77.3089% -0.0146%
================================================
Files 412 412
Lines 85542 85571 +29
================================================
+ Hits 66144 66154 +10
- Misses 14383 14391 +8
- Partials 5015 5026 +11 |
|
/run-all-tests |
|
/rebuild |
alivxxx
reviewed
Apr 29, 2019
zz-jason
reviewed
Apr 29, 2019
alivxxx
reviewed
Apr 29, 2019
qw4990
reviewed
Apr 30, 2019
qw4990
reviewed
Apr 30, 2019
zz-jason
reviewed
May 7, 2019
XuHuaiyu
force-pushed
the
dup_history_stats
branch
from
20495fe
to
42d045d
Compare
zz-jason
reviewed
May 7, 2019
server/statistics_handler.go
Outdated
| store, ok := s.driver.(*TiDBDriver) | ||
| if !ok { | ||
| panic("Illegal driver") | ||
| h.err = errors.New(fmt.Sprintf("illegal driver, excepted TiDBDriver, but got %T", s.driver)) |
XuHuaiyu
force-pushed
the
dup_history_stats
branch
from
ac928d3
to
a913b80
Compare
|
/run-all-tests |
XuHuaiyu
added
status/all tests passed
status/LGT1
alivxxx
reviewed
May 7, 2019
alivxxx
added
status/LGT2
alivxxx
pushed a commit
to alivxxx/tidb
that referenced
this pull request
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support dump history statistics
What is changed and how it works?
Add a new http-api
tidb_ip/status_port/stats/dump/time_strto fetch history statistics specified bytime_str.e.g.
tidb_ip/status_port/stats/dump/20190428173900will fetch the statistics in2019-04-28 17:39:00.Check List
Tests
Code changes
Side effects
N/A
Related changes