chunk: change offset type to int64 #10348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10348 +/- ##
================================================
+ Coverage 77.6755% 77.6768% +0.0012%
================================================
Files 411 411
Lines 85440 85427 -13
================================================
- Hits 66366 66357 -9
+ Misses 14113 14109 -4
Partials 4961 4961 |
zz-jason
added
sig/execution
|
/run-all-tests |
alivxxx
added
status/LGT2
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
May 5, 2019
zz-jason
added a commit
that referenced
this pull request
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The max-length of a string field can be 6M, a typical batch size for Chunk is 1024, which is 1K. That is to say, the memory offset of a string column can be 6GB, which exceeds int32
What is changed and how it works?
change offset type from int32 to int64
Check List
Tests
Related changes