planner: fix wrong column calculation in ColumnPruning for LogicalUnionAll #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
reviewed
May 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #10384 +/- ##
===============================================
- Coverage 77.353% 77.3525% -0.0006%
===============================================
Files 412 412
Lines 85729 85705 -24
===============================================
- Hits 66314 66295 -19
+ Misses 14386 14381 -5
Partials 5029 5029 |
|
/run-all-tests |
erjiaqing
added a commit
to erjiaqing/tidb
that referenced
this pull request
May 10, 2019
zz-jason
pushed a commit
that referenced
this pull request
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10341
What is changed and how it works?
Wrongly used Children()[0].Schema().Columns in ColumnPruning for LogicalUnionAll.
ColumnPruning for LogicalUnionAll calculate its own Columns instead of use Childres's, which will lead to wrong column names.
For column name in LogicalUnionAll contains table name (AsName in ast), but logicalProjection does not and should not contain table name.
Check List
Tests