Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix wrong column calculation in ColumnPruning for LogicalUnionAll #10384

Merged
merged 9 commits into from May 8, 2019

Conversation

Projects
None yet
5 participants
@erjiaqing
Copy link
Contributor

commented May 8, 2019

What problem does this PR solve?

Fix #10341

What is changed and how it works?

Wrongly used Children()[0].Schema().Columns in ColumnPruning for LogicalUnionAll.

ColumnPruning for LogicalUnionAll calculate its own Columns instead of use Childres's, which will lead to wrong column names.

For column name in LogicalUnionAll contains table name (AsName in ast), but logicalProjection does not and should not contain table name.

Check List

Tests

  • Unit test

erjiaqing added some commits May 7, 2019

@erjiaqing erjiaqing requested review from winoros and zz-jason May 8, 2019

Fix
@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #10384 into master will decrease coverage by 0.0005%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##            master     #10384        +/-   ##
===============================================
- Coverage   77.353%   77.3525%   -0.0006%     
===============================================
  Files          412        412                
  Lines        85729      85705        -24     
===============================================
- Hits         66314      66295        -19     
+ Misses       14386      14381         -5     
  Partials      5029       5029
@winoros
Copy link
Member

left a comment

lgtm

@eurekaka
Copy link
Contributor

left a comment

LGTM

@eurekaka eurekaka added the status/LGT2 label May 8, 2019

@erjiaqing

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

/run-all-tests

lamxTyler and others added some commits May 8, 2019

@ngaut ngaut merged commit 78ecec4 into pingcap:master May 8, 2019

5 of 6 checks passed

ci/circleci CircleCI is running your tests
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@erjiaqing erjiaqing deleted the erjiaqing:issue_10341 branch May 9, 2019

erjiaqing added a commit to erjiaqing/tidb that referenced this pull request May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.