Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,privilege: fix "show grants" result for RBAC #10571

Merged
merged 2 commits into from
May 24, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Fix #10549

What is changed and how it works?

  1. "show grants" returns the privileges including current active rule, while "show grants for current_user" doesn't
  2. "set default role for" should flush privilege

Check List

Tests

  • Unit test

1. "show grants" returns the privileges including current active rule,
while "show grants for current_user" doesn't
2. "set default role for" should flush privilege
@tiancaiamao tiancaiamao added type/bug-fix This PR fixes a bug. sig/execution SIG execution labels May 22, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @imtbkcat

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

PTAL @imtbkcat

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC doesn't work as expect
3 participants