Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema/slow_query: add host column in slow_query table. #10693

Merged
merged 9 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@crazycs520
Copy link
Contributor

commented Jun 4, 2019

What problem does this PR solve?

Add host field to classification by host.

What is changed and how it works?

Add host field column to slow_query table. This is split value of "user".

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Show resolved Hide resolved infoschema/slow_log.go Outdated
Show resolved Hide resolved infoschema/slow_log.go Outdated
@@ -162,6 +163,7 @@ type slowQueryTuple struct {
time time.Time
txnStartTs uint64
user string
ip string

This comment has been minimized.

Copy link
@zz-jason

zz-jason Jun 4, 2019

Member

I think host is better

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #10693 into master will increase coverage by 0.0318%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10693        +/-   ##
================================================
+ Coverage   78.3279%   78.3598%   +0.0318%     
================================================
  Files           414        414                
  Lines         87666      87721        +55     
================================================
+ Hits          68667      68738        +71     
+ Misses        13854      13841        -13     
+ Partials       5145       5142         -3
@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #10693 into master will decrease coverage by 0.0011%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10693        +/-   ##
================================================
- Coverage   79.6423%   79.6412%   -0.0012%     
================================================
  Files           414        414                
  Lines         87731      87736         +5     
================================================
+ Hits          69871      69874         +3     
- Misses        12688      12689         +1     
- Partials       5172       5173         +1

crazycs520 and others added some commits Jun 4, 2019

Update infoschema/slow_log.go
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
Update infoschema/slow_log.go
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Jun 4, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

/run-all-tests

@bb7133 bb7133 changed the title infoschema/slow_query: add ip column in slow_query table. infoschema/slow_query: add host column in slow_query table. Jun 4, 2019

@bb7133

bb7133 approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

LGTM

@zz-jason zz-jason merged commit 4ef9440 into pingcap:master Jun 4, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.0011% but relative coverage increased by +20.3576% compared to ea489c8
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.