store/tikv/range_task: Fix unnecessary loop; add tests for failures of RangeTaskRunner #10708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #10708 +/- ##
================================================
+ Coverage 79.8187% 79.8381% +0.0194%
================================================
Files 415 415
Lines 88290 88251 -39
================================================
- Hits 70472 70458 -14
+ Misses 12605 12580 -25
Partials 5213 5213 |
|
LGTM |
|
/run-all-tests |
|
PTAL @disksing |
disksing
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
What problem does this PR solve?
In
range_task.go, Thebreakstatement breaks theselectrather than the outerfor. At first I thought it would be a severe bug, but then I realized that it doesn't affect the correctness. It just causes some unnecessary loops in failures. This PR fixed it.By the way some tests are added to ensure when one of the subtasks returns error, the whole task returns error. I wrote it because I thought the incorrect
breakstatement might cause any severe bug, but it actually not. But after all, this test is still useful, I think. So I kept it.What is changed and how it works?
breakstatement breaks the outerforloopCheck List
Tests