store/tikv: fix performance issue under mixed transaction mode #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
store/tikv/2pc.go
Outdated
| @@ -538,6 +538,19 @@ func (c *twoPhaseCommitter) prewriteSingleBatch(bo *Backoffer, batch batchKeys) | |||
| if err1 != nil { | |||
| return errors.Trace(err1) | |||
| } | |||
| if !c.isPessimistic && lock.TTL >= uint64(config.MinPessimisticTTL/time.Millisecond) { | |||
There was a problem hiding this comment.
Large transaction's TTL may be greater than MinPessimisticTTL. The comment below isn't accurate.
Codecov Report
@@ Coverage Diff @@
## master #10847 +/- ##
================================================
- Coverage 80.9119% 80.8867% -0.0253%
================================================
Files 419 419
Lines 88663 88666 +3
================================================
- Hits 71739 71719 -20
- Misses 11703 11727 +24
+ Partials 5221 5220 -1 |
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
|
LGTM |
youjiali1995
added
status/LGT2
|
/run-all-tests |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
tiancaiamao
approved these changes
Jun 20, 2019
coocood
added a commit
to coocood/tidb
that referenced
this pull request
Jun 20, 2019
coocood
added a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The reason is that if an optimistic wait for a pessimistic lock during prewrite, the other successfully written prewrite locks blocks all the reads.
What is changed and how it works?
Check List
Tests
Related changes