New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix 'alter table drop partition' check on hash partitioned table #10902
Conversation
PTAL @crazycs520 @winkyao @zimulala |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #10902 +/- ##
================================================
+ Coverage 81.0505% 81.0714% +0.0208%
================================================
Files 419 419
Lines 88826 88892 +66
================================================
+ Hits 71994 72066 +72
+ Misses 11603 11601 -2
+ Partials 5229 5225 -4 |
/run-all-tests |
/rebuild |
1 similar comment
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
What problem does this PR solve?
Before:
After:
What is changed and how it works?
Forbid drop partition operation on a hash partitioned table.
Check List
Tests
Related changes