executor: fix autoid doesn't handle float, double type and tiny cleanup #11110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11110 +/- ##
===========================================
Coverage 81.3669% 81.3669%
===========================================
Files 423 423
Lines 90479 90479
===========================================
Hits 73620 73620
Misses 11574 11574
Partials 5285 5285 |
|
/run-all-tests |
|
@tiancaiamao @lysu PTAL |
crazycs520
added
type/bug-fix
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
lzmhhh123
reviewed
Jul 8, 2019
winkyao
reviewed
Jul 8, 2019
|
There's another case the pr doesn't handle. eg: update stmt. I would like to mark the pr to "WIP". And more test case should add also. |
nange
changed the title
nange
changed the title
|
@winkyao @lzmhhh123 please review again, thanks. |
|
/run-all-tests |
|
/run-all-tests |
|
PTAL @winkyao |
|
PTAL @crazycs520 @lzmhhh123 |
zimulala
reviewed
Jul 19, 2019
executor/insert_test.go
Outdated
| { | ||
| `insert into t4(id) values(6)`, | ||
| `select * from t4 where id = 6`, | ||
| testkit.Rows(`6 6`), |
There was a problem hiding this comment.
It isn't compatible with MySQL5.7, the result of MySQL is as follows:
mysql> select * from t4 where id = 6;
+----+---+
| id | n |
+----+---+
| 6 | 7 |
+----+---+
1 row in set (0.01 sec)
There was a problem hiding this comment.
@zimulala fixed! thank you!
BTW, the update behavior is the same as MySQL8.0, but is not the same as MySQL5.7. I think the behavior of MySQL8.0 is expected to me.
lzmhhh123
added
needs-cherry-pick-2.1
status/LGT1
|
/run-all-tests |
lzmhhh123
added
status/all tests passed
status/LGT2
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
This was referenced Jul 23, 2019
lzmhhh123
pushed a commit
to lzmhhh123/tidb
that referenced
this pull request
Jul 23, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jul 24, 2019
…origin-release-3.0
imtbkcat
pushed a commit
to lzmhhh123/tidb
that referenced
this pull request
Jul 26, 2019
…origin-release-3.0
sre-bot
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jul 26, 2019
…origin-release-3.0
eurekaka
pushed a commit
that referenced
this pull request
Jul 26, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jun 11, 2021
pingcap#11110 Signed-off-by: crazycs <crazycs520@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #11109
What is changed and how it works?
modify the
adjustAutoIncrementDatummethod logic, handle the float and double scenario.Check List
Tests
Code changes
Side effects
Related changes