session: do not keep history when the transaction retry is disabled #11192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11192 +/- ##
===========================================
Coverage 81.3852% 81.3852%
===========================================
Files 423 423
Lines 90584 90584
===========================================
Hits 73722 73722
Misses 11555 11555
Partials 5307 5307 |
coocood
reviewed
Jul 11, 2019
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
coocood
reviewed
Jul 11, 2019
session/session.go
Outdated
| } | ||
|
|
||
| // If retry limit is 0, the transaction could not retry. | ||
| couldRetry := sessVars.RetryLimit != 0 |
There was a problem hiding this comment.
This may be better.
if sessVars.RetryLimit == 0 {
return false
}
if ... {
return true
}
if ... {
return true
}
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
coocood
reviewed
Jul 11, 2019
session/session_test.go
Outdated
| tk.MustExec("create table history (a int)") | ||
| tk.MustExec("insert history values (1)") | ||
|
|
||
| // Firstly, disable retry. |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
|
LGTM |
|
/run-all-tests |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
If the transaction retry is disabled, it is not necessary to add history.
What is changed and how it works?
Do not keep history when the transaction retry is disabled.
Check List
Tests
Make many statements in one transaction, the memory of statement context released in this PR.
Code changes
Side effects
If we don't keep history, the stmt-count-limit is useless.
Related changes