Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: avoid tidb-server -h output test flags #11209

Merged
merged 4 commits into from Jul 12, 2019

Conversation

tptpp
Copy link
Contributor

@tptpp tptpp commented Jul 11, 2019

What problem does this PR solve?

tidb-server -h output test flags
#10975

What is changed and how it works?

adjust testing code dependency, add build tags 'codes' to code and makefile.
these code would not build into tidb binary file

Check List

Tests

  • Manual test (add detailed scripts or steps below)
➜  tidb git:(tptpp/usage-test-flags) ./bin/tidb-server -h
Usage of ./bin/tidb-server:
  -L string
    	log level: info, debug, warn, error, fatal (default "info")
  -P string
    	tidb server port (default "4000")
  -V	print version information and exit (default false)
  -advertise-address string
    	tidb server advertise IP
  -affinity-cpus string
    	affinity cpu (cpu-no. separated by comma, e.g. 1,2,3)
  -config string
    	config file path
  -config-check
    	check config file validity and exit (default false)
  -config-strict
    	enforce config file validity (default false)
  -cors string
    	tidb server allow cors origin
  -enable-binlog
    	enable generate binlog (default false)
  -host string
    	tidb server host (default "0.0.0.0")
  -lease string
    	schema lease duration, very dangerous to change only if you know what you do (default "45s")
  -log-file string
    	log file path
  -log-slow-query string
    	slow query file path
  -metrics-addr string
    	prometheus pushgateway address, leaves it empty will disable prometheus push.
  -metrics-interval uint
    	prometheus client push interval in second, set "0" to disable prometheus push. (default 15)
  -path string
    	tidb storage path (default "/tmp/tidb")
  -plugin-dir string
    	the folder that hold plugin (default "/data/deploy/plugin")
  -plugin-load string
    	wait load plugin name(separated by comma)
  -proxy-protocol-header-timeout uint
    	proxy protocol header read timeout, unit is second. (default 5)
  -proxy-protocol-networks string
    	proxy protocol networks allowed IP or *, empty mean disable proxy protocol support
  -report-status
    	If enable status report HTTP service. (default true)
  -run-ddl
    	run ddl worker on this tidb-server (default true)
  -socket string
    	The socket file to use for connection.
  -status string
    	tidb server status port (default "10080")
  -status-host string
    	tidb server status host (default "0.0.0.0")
  -store string
    	registered store name, [tikv, mocktikv] (default "mocktikv")
  -token-limit int
    	the limit of concurrent executed sessions (default 1000)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #11209 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11209   +/-   ##
===========================================
  Coverage   81.2576%   81.2576%           
===========================================
  Files           423        423           
  Lines         90234      90234           
===========================================
  Hits          73322      73322           
  Misses        11615      11615           
  Partials       5297       5297

@tptpp tptpp marked this pull request as ready for review July 11, 2019 07:10
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added contribution This PR is from a community contributor. component/test labels Jul 12, 2019
@jackysp jackysp changed the title isolate testing code *: isolate testing code Jul 12, 2019
@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2019
@lysu
Copy link
Collaborator

lysu commented Jul 12, 2019

/rebuild

@lysu
Copy link
Collaborator

lysu commented Jul 12, 2019

/run-all-tests

@lysu lysu added needs-cherry-pick-3.0 status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2019
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit ad404bb into pingcap:master Jul 12, 2019
@lysu
Copy link
Collaborator

lysu commented Jul 12, 2019

@tptpp Thank you for your contribution!

@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @jackysp PTAL.

jackysp pushed a commit to jackysp/tidb that referenced this pull request Apr 8, 2020
@jackysp jackysp changed the title *: isolate testing code *: avoid tidb-server -h output test flags Apr 8, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants