Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix delete error when convert string to float or int (#10861) #11279

Merged
merged 2 commits into from Jul 17, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 16, 2019

cherry-pick #10861 to release-2.1

@sre-bot sre-bot added sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/2.1 cherry-pick type/bug-fix This PR fixes a bug. labels Jul 16, 2019
@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 17, 2019
@zz-jason zz-jason requested review from alivxxx and qw4990 July 17, 2019 02:22
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 17, 2019
@zz-jason zz-jason merged commit 89032d7 into pingcap:release-2.1 Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants