Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix the parallel problem of "set default value" and other DDL (#11341) #11374

Merged
merged 4 commits into from Jul 25, 2019
Merged

ddl: fix the parallel problem of "set default value" and other DDL (#11341) #11374

merged 4 commits into from Jul 25, 2019

Conversation

zimulala
Copy link
Contributor

cherry-pick #11341 to release-2.1

@zimulala
Copy link
Contributor Author

PTAL @crazycs520 @winkyao

crazycs520
crazycs520 reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@zimulala
Copy link
Contributor Author

PTAL @bb7133 @winkyao

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2019
bb7133
bb7133 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AilinKid
AilinKid reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 25, 2019

@zimulala merge failed.

@zimulala zimulala merged commit 4ee1c52 into pingcap:release-2.1 Jul 25, 2019
@zimulala zimulala deleted the set-default-value branch July 25, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@crazycs520 crazycs520 crazycs520 left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zimulala @crazycs520 @sre-bot @bb7133 @AilinKid