ddl: fix a bug that adding range partition meets error when value is negative #11407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @crazycs520 @zimulala @winkyao |
Codecov Report
@@ Coverage Diff @@
## master #11407 +/- ##
===========================================
Coverage 81.2765% 81.2765%
===========================================
Files 426 426
Lines 92184 92184
===========================================
Hits 74924 74924
Misses 11905 11905
Partials 5355 5355 |
|
PTAL @crazycs520 @zimulala @winkyao |
winkyao
reviewed
Jul 26, 2019
| for ith, def := range spec.PartDefinitions { | ||
| if err := def.Clause.Validate(part.Type, len(part.Columns)); err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| // For RANGE partition only VALUES LESS THAN should be possible. | ||
| clause := def.Clause.(*ast.PartitionDefinitionClauseLessThan) | ||
| for _, expr := range clause.Exprs { |
There was a problem hiding this comment.
Why just remove it? Could we refine the checking?
There was a problem hiding this comment.
As you see, there are no test cases break and I'm adding new test cases, so it's fine to remove it.
|
/run-all-tests |
tiancaiamao
added
status/all tests passed
status/can-merge
|
/run-all-tests |
lysu
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
and also this one:
What is changed and how it works?
In this line https://github.com/pingcap/tidb/compare/master...tiancaiamao:fix-add-range-partition?expand=1#diff-edfa54cbe2fdb418f0a77bd0ec4a56f2L3395, we check the expression to be an integer.
However,
expr.GetType()returns unspecified type and the error is throw out.After removing that, I meet another error, here https://github.com/pingcap/tidb/compare/master...tiancaiamao:fix-add-range-partition?expand=1#diff-edfa54cbe2fdb418f0a77bd0ec4a56f2L2145
checkAddPartitionValuethis function also asserts the partition less than value to be a simple integer,so I replace it with another one.
Check List
Tests
Related changes