Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: reject invalid conversion from like to = (#11320) #11411

Merged
merged 3 commits into from
Jul 24, 2019
Merged

planner: reject invalid conversion from like to = (#11320) #11411

merged 3 commits into from
Jul 24, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 24, 2019

cherry-pick #11320 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 24, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 24, 2019
Merged
@sre-bot sre-bot added sig/planner SIG: Planner contribution This PR is from a community contributor. type/3.0 cherry-pick type/bug-fix This PR fixes a bug. labels Jul 24, 2019
zz-jason
zz-jason reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
@zz-jason zz-jason requested a review from qw4990 July 24, 2019 10:59
qw4990
qw4990 approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 24, 2019
@zz-jason zz-jason merged commit 68acdce into pingcap:release-3.0 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sre-bot @zz-jason @qw4990 @wjhuang2016