plugin: fix null domain when load with plugin in 2.1 #11426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
|
@tiancaiamao PTAL |
|
ping @tiancaiamao |
1 similar comment
|
ping @tiancaiamao |
|
LGTM |
tiancaiamao
approved these changes
Jul 29, 2019
tiancaiamao
added
the
status/can-merge
tiancaiamao
added
status/LGT2
|
/run-all-tests |
|
@lysu merge failed. |
|
/rebuild |
|
/run-all-tests |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix NPE when plugin call Get domain in OnInit impl
this only affect on 2.1 that loaded with plugin need get domain in OnInit
What is changed and how it works?
cherry-pick miss c3f64b2#diff-5c9d0559245b0eecd9e72c2ec9562ac5R53 part
and let OnInit only be called in Init
Check List
Tests
Code changes
Side effects
Related changes