http: add region-id when getting mvcc by handle #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11436 +/- ##
===========================================
Coverage 81.2701% 81.2701%
===========================================
Files 425 425
Lines 92067 92067
===========================================
Hits 74823 74823
Misses 11860 11860
Partials 5384 5384 |
jackysp
reviewed
Jul 26, 2019
server/http_handler.go
Outdated
| @@ -1293,6 +1310,9 @@ func (h mvccTxnHandler) handleMvccGetByKey(params map[string]string, decodeData | |||
| colMap[col.ID] = &col.FieldType | |||
| } | |||
|
|
|||
| if err != nil { | |||
jackysp
reviewed
Jul 26, 2019
server/http_handler.go
Outdated
| Value *kvrpcpb.MvccGetByKeyResponse `json:"value"` | ||
| Key string `json:"key"` | ||
| Value *kvrpcpb.MvccGetByKeyResponse `json:"value"` | ||
| RegionID uint64 `json:"region-id"` |
jackysp
reviewed
Jul 30, 2019
server/http_handler.go
Outdated
| if err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| keyLocation, err := t.RegionCache.LocateKey(tikv.NewBackoffer(context.Background(), 500), encodedKey) |
There was a problem hiding this comment.
There are many similar code like this. It is better to extract a function for it.
|
/run-all-tests |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11557 |
sre-bot
added a commit
that referenced
this pull request
Aug 1, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @imtbkcat PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
return region id when getting mvcc info by handle.
What is changed and how it works?
Add
region-idfield, and get region info inhandleMvccGetByKey.Check List
Tests
Code changes
Side effects
Related changes