Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: forbid to try to get a connection forever (#11391) #11531

Merged
merged 5 commits into from Aug 2, 2019
Merged

tikv: forbid to try to get a connection forever (#11391) #11531

merged 5 commits into from Aug 2, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jul 30, 2019

cherry-pick #11391

@jackysp
Copy link
Member

jackysp commented Jul 30, 2019

Please fix CI, @hicqu .

@jackysp
fix CI
dbc9fd5 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp
jackysp reviewed Aug 2, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2019
lysu
lysu previously approved these changes Aug 2, 2019
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

@hicqu merge failed.

@jackysp jackysp added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 2, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

@hicqu merge failed.

@jackysp
make the case stable
b954e72 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp added status/can-merge Indicates a PR has been approved by a committer. priority/release-blocker This PR blocks a release. Please review it ASAP. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 2, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

/run-all-tests

@jackysp jackysp merged commit 540dd06 into pingcap:release-3.0 Aug 2, 2019
@hicqu hicqu deleted the release-3.0 branch August 5, 2019 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@lysu lysu lysu left review comments

Assignees
No one assigned
Labels
component/tikv priority/release-blocker This PR blocks a release. Please review it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hicqu @jackysp @sre-bot @lysu