Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in ConvertJSONToInt error msg (#11493) #11534

Merged
merged 5 commits into from
Aug 1, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 31, 2019

cherry-pick #11493 to release-3.0

Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 31, 2019

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 1, 2019

@sre-bot merge failed.

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 1, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 1, 2019

@sre-bot merge failed.

@zz-jason zz-jason closed this Aug 1, 2019
@zz-jason zz-jason reopened this Aug 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Aug 1, 2019

/run-unit-test

@zz-jason zz-jason merged commit b90f0dd into pingcap:release-3.0 Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants