Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: convert EOF error to ErrTruncate when parse duration (#11865) #11910

Merged
merged 4 commits into from
Aug 29, 2019

Conversation

wjhuang2016
Copy link
Member

What problem does this PR solve?

cherry-pick #11865 to release-2.1

What is changed and how it works?

convert EOF error to ErrTruncate

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Release note

@wjhuang2016 wjhuang2016 changed the title check warnings types: convert EOF error to ErrTruncate when parse duration Aug 28, 2019
@wjhuang2016
Copy link
Member Author

/run-all-tests

@wjhuang2016
Copy link
Member Author

/run-all-tests

@Deardrops
Copy link
Contributor

LGTM

@Deardrops Deardrops added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 29, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjhuang2016 wjhuang2016 changed the title types: convert EOF error to ErrTruncate when parse duration types: convert EOF error to ErrTruncate when parse duration (##11865) Aug 29, 2019
@wjhuang2016 wjhuang2016 changed the title types: convert EOF error to ErrTruncate when parse duration (##11865) types: convert EOF error to ErrTruncate when parse duration (#11865) Aug 29, 2019
@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2019
@zz-jason zz-jason merged commit c8a0f2d into pingcap:release-2.1 Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants