Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: convert EOF error to ErrTruncate when parse duration (#11865) #11910

Merged
merged 4 commits into from Aug 29, 2019

Conversation

@wjhuang2016
Copy link
Member

wjhuang2016 commented Aug 28, 2019

What problem does this PR solve?

cherry-pick #11865 to release-2.1

What is changed and how it works?

convert EOF error to ErrTruncate

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Release note

@wjhuang2016 wjhuang2016 changed the title check warnings types: convert EOF error to ErrTruncate when parse duration Aug 28, 2019
@wjhuang2016 wjhuang2016 force-pushed the wjhuang2016:release-2.1 branch from db6aefe to 6b60704 Aug 28, 2019
@wjhuang2016

This comment has been minimized.

Copy link
Member Author

wjhuang2016 commented Aug 28, 2019

/run-all-tests

@wjhuang2016

This comment has been minimized.

Copy link
Member Author

wjhuang2016 commented Aug 29, 2019

/run-all-tests

@Deardrops

This comment has been minimized.

Copy link
Member

Deardrops commented Aug 29, 2019

LGTM

Copy link
Member

zz-jason left a comment

LGTM

@wjhuang2016 wjhuang2016 changed the title types: convert EOF error to ErrTruncate when parse duration types: convert EOF error to ErrTruncate when parse duration (##11865) Aug 29, 2019
@wjhuang2016 wjhuang2016 changed the title types: convert EOF error to ErrTruncate when parse duration (##11865) types: convert EOF error to ErrTruncate when parse duration (#11865) Aug 29, 2019
@zz-jason zz-jason merged commit c8a0f2d into pingcap:release-2.1 Aug 29, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.