Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load data : fix load data rowCount should added first before call colsToRow(). (#11980) #11994

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Sep 3, 2019

What problem does this PR solve?

cherry-pick to release 2.1 #11980

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix load data rowCount should added first before call colsToRow().

…ingcap#11980)

fix load data rowcount should added first before call colsToRow().
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat
Copy link

imtbkcat commented Sep 3, 2019

/run-all-tests

@imtbkcat imtbkcat added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 3, 2019
@AilinKid AilinKid added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 3, 2019

Sorry @AilinKid, you don't have permission to trigger auto merge event on this branch.

@winkyao winkyao merged commit 7d5971b into pingcap:release-2.1 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants