Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptikvclient: add metrics for gRPC connection transient failure (#12084) #12092
Conversation
|
LGTM |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
sre-bot
commented
Sep 9, 2019
|
/run-all-tests |
This was referenced Sep 9, 2019
sre-bot
merged commit ebf7d8f
into
pingcap:release-2.1
13 checks passed
13 checks passed
This comment has been minimized.
This comment has been minimized.
|
/bench |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lonng commentedSep 9, 2019
Signed-off-by: Lonng heng@lonng.org
Cherry-pick #12084 for release-2.1
What problem does this PR solve?
TiDB access to TiKV through gRPC requests. If the underlying socket is disconnected, gRPC will try to reconnect to the underlying socket, which may cause the request delay to jitter. We need to way to monitor the low-level socket state change.
What is changed and how it works?
This PR adds a metric to monitor the gRPC connection state, the metric will record the connection state before sending the request to TiKV. We can diagnose the delay jitter by
rate(tidb_grpc_connection_state)after this PR merged.Check List
Tests
Related changes
Release note