Makefile: gotest, froze TZ for unixtime test #12226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM |
tiancaiamao
added
status/LGT2
tiancaiamao
approved these changes
Sep 17, 2019
tiancaiamao
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12226 +/- ##
===========================================
Coverage 81.1375% 81.1375%
===========================================
Files 454 454
Lines 98524 98524
===========================================
Hits 79940 79940
Misses 12829 12829
Partials 5755 5755 |
|
@ekalinin Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Without this fix i could not run tests:
$ make gotest ... ---------------------------------------------------------------------- FAIL: simple_rewriter_test.go:22: testEvaluatorSuite.TestSimpleRewriter simple_rewriter_test.go:172: c.Assert(num, Equals, int64(1209571200)) ... obtained int64 = 1209585600 ... expected int64 = 1209571200 ...It looks like the root of this fail is that my time zone is different from time zone where tests usually run.
What is changed and how it works?
Time zone was hard coded before tests.
Check List
Tests