tikvclient: adjust log level in store/tikv/client_batch.go #12302
Conversation
Signed-off-by: qupeng <qupeng@pingcap.com>
store/tikv/client_batch.go
Outdated
| @@ -215,8 +215,8 @@ func (c *batchCommandsClient) send(request *tikvpb.BatchCommandsRequest, entries | |||
| c.batched.Store(requestID, entries[i]) | |||
| } | |||
| if err := c.client.Send(request); err != nil { | |||
| logutil.BgLogger().Error( | |||
| "batch commands send error", | |||
| logutil.BgLogger().Warn( | |||
There was a problem hiding this comment.
can we set it to debug or info? or can we not print this message since the user no need to worry about these kinds of logs?
There was a problem hiding this comment.
I prefer to set it to info if you think it's better.
Except waitting responses. In this case logs will be printed when responses are not received after 60s. Signed-off-by: qupeng <qupeng@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## master #12302 +/- ##
===========================================
Coverage 80.8442% 80.8442%
===========================================
Files 454 454
Lines 99756 99756
===========================================
Hits 80647 80647
Misses 13318 13318
Partials 5791 5791 |
Signed-off-by: qupeng <qupeng@pingcap.com>
… recycle-conn-without-log
|
PTAL @zz-jason @tiancaiamao |
|
@hicqu please follow the Commit Message and Pull Request Style guide to reformat the PR title. BTW, please add some proper labels for this PR. |
hicqu
changed the title
|
PTAL @zz-jason |
|
LGTM |
tiancaiamao
added
component/DDL-need-LGT3
status/LGT1
lysu
added
require-LGT3
| @@ -215,8 +215,8 @@ func (c *batchCommandsClient) send(request *tikvpb.BatchCommandsRequest, entries | |||
| c.batched.Store(requestID, entries[i]) | |||
| } | |||
| if err := c.client.Send(request); err != nil { | |||
| logutil.BgLogger().Error( | |||
| "batch commands send error", | |||
| logutil.BgLogger().Info( | |||
There was a problem hiding this comment.
which metric can we use to identity send failure if user use error/warn level
There was a problem hiding this comment.
Seems in the module there is no such metric. Is it better to put the metric into SendRequest callers?
|
LGTM |
|
cherry pick to release-3.0 failed |
…2302) Signed-off-by: qupeng <qupeng@pingcap.com>
What problem does this PR solve?
Some error logs could make users confused.
What is changed and how it works?
Change some log level from Error to Warn, because TiDB can auto recover from those errors.
Check List
Tests
No code. Because it just adjusts log level.
Code changes
Checked.
Side effects
No.
Related changes
Need to cherry-pick to release-3.0.
Release note
No.