Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: record slow-log when log use error level #12359

Merged
merged 4 commits into from Sep 25, 2019
Merged

executor: record slow-log when log use error level #12359

merged 4 commits into from Sep 25, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Sep 24, 2019 •
edited

What problem does this PR solve?

when TiDB uses ERROR log level, slow-log will not be output.

What is changed and how it works?

record slow-log even if use ERROR

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

Release note

  • executor: record slow-log when log use error level

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited

Codecov Report

Merging #12359 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12359   +/-   ##
===========================================
  Coverage   80.8468%   80.8468%           
===========================================
  Files           454        454           
  Lines         99900      99900           
===========================================
  Hits          80766      80766           
  Misses        13335      13335           
  Partials       5799       5799

zz-jason
zz-jason reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2019
@lysu
Copy link
Collaborator Author

lysu commented Sep 24, 2019

/run-unit-test

ngaut
ngaut approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

@lysu merge failed.

@lysu lysu added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit e414589 into pingcap:master Sep 25, 2019
@sre-bot sre-bot mentioned this pull request Sep 25, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

cherry pick to release-2.1 in PR #12373

@sre-bot sre-bot mentioned this pull request Sep 25, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

cherry pick to release-3.1 in PR #12375

@sre-bot sre-bot mentioned this pull request Sep 25, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

cherry pick to release-3.0 in PR #12377

sre-bot added a commit that referenced this pull request Sep 25, 2019
@sre-bot
executor: record slow-log when log use error level (#12359) (#12373)
3b8445d
sre-bot added a commit that referenced this pull request Sep 25, 2019
@sre-bot
executor: record slow-log when log use error level (#12359) (#12377)
7c48202
sre-bot added a commit that referenced this pull request Sep 25, 2019
@sre-bot
executor: record slow-log when log use error level (#12359) (#12375)
01d15c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@ngaut ngaut ngaut approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lysu @sre-bot @ngaut @zz-jason