Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: allow multiple unique attributes in a column (#12165) #12463

Merged
merged 7 commits into from Oct 13, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 28, 2019

cherry-pick #12165 to release-3.0


What problem does this PR solve?

Fix #12006.

What is changed and how it works?

Remove constraint name assignment when building ast.Constraint from Option of ast.ColumnDef. Let checkConstraintNames determine the name later to avoid the name duplication.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Allow multiple unique attributes in a column

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 28, 2019

/run-all-tests

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/DDL-need-LGT3 status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 13, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit 95aac16 into pingcap:release-3.0 Oct 13, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants