Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add index hash join benchmark #12564

Merged
merged 3 commits into from Oct 9, 2019
Merged

executor: add index hash join benchmark #12564

merged 3 commits into from Oct 9, 2019

Conversation

lzmhhh123
Copy link
Member

What problem does this PR solve?

Add index hash join benchmark

What is changed and how it works?

Build a pseudo index reader for index join benchmark.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has persistent data change

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Oct 9, 2019

@lzmhhh123 test failed

XuHuaiyu
XuHuaiyu reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SunRunAway
SunRunAway approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

Your auto merge job has been accepted, waiting for 12558

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0ec38f7). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             master    #12564   +/-   ##
==========================================
  Coverage          ?   79.865%           
==========================================
  Files             ?       460           
  Lines             ?    102856           
  Branches          ?         0           
==========================================
  Hits              ?     82146           
  Misses            ?     14719           
  Partials          ?      5991

@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

/run-all-tests

@sre-bot sre-bot merged commit a177d46 into pingcap:master Oct 9, 2019
@lzmhhh123 lzmhhh123 deleted the dev/add_index_join_benchmark branch October 9, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees
No one assigned
Labels
component/test sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lzmhhh123 @XuHuaiyu @sre-bot @SunRunAway