Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: speed up unit tests under the expression package #12887

Merged
merged 15 commits into from Oct 23, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Oct 23, 2019

What problem does this PR solve?

Speed up unit tests under the expression package.

What is changed and how it works?

Move leak tests from Suite and Tests into TestT Func and make some tests run parallelly.

Check List

Tests

  • Unit test

@qw4990 qw4990 requested a review from a team as a code owner October 23, 2019 02:36
@ghost ghost requested review from wshwsh12 and removed request for a team October 23, 2019 02:36
@qw4990 qw4990 changed the title expression: speed up unit tests under expression package expression: speed up unit tests under the expression package Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #12887 into master will decrease coverage by 0.536%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##            master    #12887        +/-   ##
==============================================
- Coverage   80.504%   79.968%   -0.5361%     
==============================================
  Files          465       465                
  Lines       109941    107029      -2912     
==============================================
- Hits         88507     85589      -2918     
- Misses       14954     14987        +33     
+ Partials      6480      6453        -27

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 23, 2019

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@bb7133 bb7133 added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 23, 2019
@zz-jason
Copy link
Member

/rebuild

@qw4990 qw4990 merged commit 5d5497b into pingcap:master Oct 23, 2019
lfkdsk added a commit to JustProject/tidb that referenced this pull request Oct 26, 2019
…ect/tidb into feature-add-udf-support

* 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits)
  *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852)
  executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889)
  planner, executor: support create view on union (pingcap#12595)
  planner/cascades: introduce TransformationID in cascades planner (pingcap#12879)
  executor: fix data race in test (pingcap#12910)
  executor: reuse chunk row for insert on duplicate update (pingcap#12847)
  ddl: speed up tests (pingcap#12888)
  executor: speed up test (pingcap#12896)
  expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886)
  expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663)
  expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674)
  expression: speed up unit tests under the expression package (pingcap#12887)
  store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872)
  executor: fix data race in `GetDirtyTable()` (pingcap#12767)
  domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578)
  executor: split test for speed up (pingcap#12881)
  executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330)
  expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841)
  tune grpc connection count between tidb and tikv (pingcap#12884)
  Makefile: change test parallel to 8 (pingcap#12885)
  ...
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants