infoschema: add TIDB_CLUSTER_CONFIG virtual table to retrieve all instance config #13063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13063 +/- ##
================================================
+ Coverage 80.1498% 80.2235% +0.0736%
================================================
Files 469 469
Lines 111823 112012 +189
================================================
+ Hits 89626 89860 +234
+ Misses 15308 15287 -21
+ Partials 6889 6865 -24 |
…tances config Signed-off-by: Lonng <heng@lonng.org>
djshow832
reviewed
Nov 4, 2019
Co-Authored-By: djshow832 <873581766@qq.com>
Signed-off-by: Lonng <heng@lonng.org>
crazycs520
reviewed
Nov 7, 2019
| @@ -1971,6 +1985,145 @@ func dataForTiDBClusterInfo(ctx sessionctx.Context) ([][]types.Datum, error) { | |||
| return rows, nil | |||
| } | |||
|
|
|||
| func dataForClusterConfig(ctx sessionctx.Context) ([][]types.Datum, error) { | |||
| sql := "SELECT type, name, address, status_address FROM INFORMATION_SCHEMA.TIDB_CLUSTER_INFO ORDER BY type" | |||
| rows, _, err := ctx.(sqlexec.RestrictedSQLExecutor).ExecRestrictedSQL(sql) | |||
There was a problem hiding this comment.
How about use dataForTiDBClusterInfo directly?
There was a problem hiding this comment.
The caller cannot assume the dataForTiDBClusterInfo results and prefer to use ORDER BY clause instead of sorting results manually.
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
56 tasks
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
In the current version, we don't have a simple way to get cluster configuration information. We need to use different HTTP interfaces of different components to retrieve them.
eg.
/pd/api/v1/config/configFurthermore, there is no an utility way to filter configuration items or aggregate them.
What is changed and how it works?
This PR introduces the
information_schema.tidb_cluster_configand make the user can retrieve cluster configuration easier viaselect * from information_schema.tidb_cluster_config.And we can filter them easily:
select * from information_schema.tidb_cluster_config where type='tikv' and `key` like 'raft%'Check List
Tests
Release note
select * from information_schema.tidb_cluster_config