Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: fix out-of-index in split-region (#12265) #13092

Merged
merged 2 commits into from Nov 4, 2019
Merged

tikv: fix out-of-index in split-region (#12265) #13092

merged 2 commits into from Nov 4, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Nov 3, 2019 •
edited

cherry-pick #12265 to 3.0

# Conflicts:
#	store/tikv/split_region.go

This change is Reviewable

@lysu
tikv: fix out-of-index in split-region (#12265)
1dbd590 
# Conflicts:
#	store/tikv/split_region.go
@lysu
Copy link
Collaborator Author

lysu commented Nov 3, 2019

/run-all-tests

@lysu lysu requested review from jackysp and zimulala November 3, 2019 09:02
jackysp
jackysp reviewed Nov 3, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2019
zimulala
zimulala approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7939e6f into pingcap:release-3.0 Nov 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2019

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lysu @sre-bot @zimulala @jackysp