store/tikv: do not backoff when PessimisticLock return locked error #13110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @coocood |
Codecov Report
@@ Coverage Diff @@
## master #13110 +/- ##
===========================================
Coverage 80.2495% 80.2495%
===========================================
Files 468 468
Lines 111172 111172
===========================================
Hits 89215 89215
Misses 15158 15158
Partials 6799 6799 |
|
LGTM |
|
PTAL @lysu |
|
LGTM |
coocood
approved these changes
Nov 4, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Nov 4, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 4, 2019
|
@tiancaiamao need cherry-pick 3.1? |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When PessimisticLock gets a locked error, TiKV has already back off before returning the response, so it's unnecessary to back off again in TiDB.
What is changed and how it works?
Reset the change here:
https://github.com/pingcap/tidb/pull/12852/files#diff-499c236856cd9ce3300d3f5ccde41a23R721
Check List
Tests