Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support adding/dropping the primary key by a configuration (#13229) #13522

Merged
merged 4 commits into from Nov 18, 2019

Conversation

zimulala
Copy link
Contributor

Cherry-pick #13229 to v3.0
Screen Shot 2019-11-15 at 17 57 52

@zimulala
Copy link
Contributor Author

PTAL @crazycs520 @jackysp @bb7133

@ericsyh
Copy link
Contributor

ericsyh commented Nov 18, 2019

@zimulala Pls fix the CI~

@ericsyh ericsyh closed this Nov 18, 2019
@ericsyh ericsyh reopened this Nov 18, 2019
@bb7133 bb7133 added the priority/release-blocker This PR blocks a release. Please review it ASAP. label Nov 18, 2019
@zimulala
Copy link
Contributor Author

We need PR#13523 to pass the unit-test.

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor Author

/run-common-test tidb-test=pr/949

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Nov 18, 2019

/run-all-tests tidb-test=pr/949

@zimulala
Copy link
Contributor Author

/run-all-tests

@zimulala zimulala merged commit 0e71fa2 into pingcap:release-3.0 Nov 18, 2019
@zimulala zimulala deleted the pk-1 branch November 18, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This PR blocks a release. Please review it ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants