planner: fix a bug for chunk cost model. #14144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alivxxx and
winoros
and removed request for
a team
eurekaka
reviewed
Dec 19, 2019
ghost
requested review from
qw4990 and
XuHuaiyu
and removed request for
a team
SunRunAway
added
status/can-merge
|
/run-all-tests |
SunRunAway
reviewed
Dec 20, 2019
| @@ -176,6 +179,9 @@ func (c *Column) AvgColSizeListInDisk(count int64) float64 { | |||
| // Keep two decimal place. | |||
| // Minus Log2(avgSize) for unfixed-len type LEN. | |||
| avgSize := float64(c.TotColSize) / float64(count) | |||
| if avgSize < 1 { | |||
| return math.Round((avgSize)*100) / 100 | |||
| } | |||
There was a problem hiding this comment.
Could you add unit test in testStatsSuite.TestAvgColLen?
wshwsh12
force-pushed
the
fix_cost_model
branch
from
1822d1b
to
620f33e
Compare
SunRunAway
added
the
status/can-merge
|
/run-all-tests |
|
@wshwsh12 merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #14146
When using chunk cost model for some table, it maybe get
Can’t find a proper physical plan for this query.What is changed and how it works?
Check
avgSizebefore usingLog2(avgSize)Check List
Tests
Code changes
Side effects
Related changes
Release note