Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: do not refresh TiFlash work index when region is refreshed in cache #14205

Merged
merged 2 commits into from
Dec 26, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

As the title says.

What is changed and how it works?

Reuse the old TiFlashWorkIdx when a new region insert into the region cache.

Check List

Tests

  • Unit test
  • Integration test

Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

Your auto merge job has been accepted, waiting for 14202

@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7a024a2 into pingcap:master Dec 26, 2019
@lzmhhh123 lzmhhh123 deleted the bug-fix/not_refresh_flash_workidx branch December 26, 2019 05:25
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants