infoschema: show information about table partitions in information_schema.PARTITIONS
#14347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangwz thanks! Could you please add some unit tests in this PR? |
tiancaiamao
reviewed
Jan 6, 2020
qw4990
reviewed
Jan 7, 2020
There was a problem hiding this comment.
@tangwz Thanks~
Please add some tests for this.
A simple way is adding some integration tests like what we do in expression/integration_test.go, for example:
MustExec("CREATE TABLE ... PARTITION ...")
results := MustQuery("SELECT * FROM INFORMATION_SCHEMA.PARTITIONS")
// check results
qw4990
reviewed
Jan 7, 2020
|
@tangwz Friendly ping, please address these comments. |
tiancaiamao
reviewed
Jan 16, 2020
qw4990
reviewed
Jan 19, 2020
qw4990
reviewed
Jan 19, 2020
55 tasks
|
@tangwz, please update your pull request. |
|
@tangwz, please update your pull request. |
|
LGTM, PTAL @tiancaiamao |
|
LGTM |
tiancaiamao
added
status/LGT2
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
tiancaiamao
approved these changes
Feb 5, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 14279 |
|
/run-all-tests |
hsqlu
pushed a commit
to hsqlu/tidb
that referenced
this pull request
Feb 8, 2020
…chema.PARTITIONS` (pingcap#14347)
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes: #13905
What is changed and how it works?
Check List
Tests