-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coprocessor: let tiflash split range task consistent with tikv #14710
coprocessor: let tiflash split range task consistent with tikv #14710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the previous changes in https://github.com/pingcap/tidb/blob/master/planner/core/find_best_task.go#L1085
need to be reverted?
I think we'd better not. The process of CBO would be affected. |
Ok, but better to revert it in the future. And the changes in https://github.com/pingcap/tidb/blob/master/planner/core/explain.go#L153 |
OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@lzmhhh123 merge failed. |
/run-unit-test |
What problem does this PR solve?
As before, we always set the full range for the region request of TiFlash. But there is some problem when we switch on the region merge. The retry of the merged region may cause the duplicate read. So TiFlash support the range in coprocessor and TiDB make the range split consistent with TiKV.
What is changed and how it works?
Make the range split of TiFlash region request consistent with TiKV.
Check List
Tests