*: fix the problem that PointGet returns wrong results in the case of overflow #14776

zimulala · 2020-02-13T07:25:45Z

What problem does this PR solve?

tidb> create table t6 (a bigint);
Query OK, 0 rows affected (0.00 sec)
tidb> insert into t6 values(9223372036854775807);
Query OK, 1 row affected (0.00 sec)
tidb> alter table t6 add unique key idx(a);
Query OK, 0 rows affected (0.04 sec)

Before this PR:

tidb> select * from t6 where a = 9223372036854775808;
+---------------------+
| a                   |
+---------------------+
| 9223372036854775807 |
+---------------------+
1 row in set, 1 warning (0.01 sec)

After this PR:

tidb>  select * from t6 where a = 9223372036854775808;
Empty set (0.00 sec)

What is changed and how it works?

Do ConvertTo to the point-get value. Handling the overflow and truncated errors.

Check List

Tests

Unit test

Related changes

Need to cherry-pick to the release branch

Release note

Write release note for bug-fix or new feature.

lzmhhh123

Please resolve conflicts and fix ci.

zimulala · 2020-03-26T03:30:03Z

PTAL @lzmhhh123

zimulala · 2020-04-14T04:11:09Z

PTAL @lzmhhh123 @XuHuaiyu

codecov · 2020-04-14T04:20:30Z

Codecov Report

Merging #14776 into master will increase coverage by 0.0609%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #14776        +/-   ##
================================================
+ Coverage   80.3457%   80.4066%   +0.0609%     
================================================
  Files           506        506                
  Lines        136968     137164       +196     
================================================
+ Hits         110048     110289       +241     
+ Misses        18304      18274        -30     
+ Partials       8616       8601        -15

bb7133 · 2020-04-14T08:58:53Z

planner/core/point_get_plan.go

@@ -652,6 +653,9 @@ func tryPointGetPlan(ctx sessionctx.Context, selStmt *ast.SelectStmt) *PointGetP
 		return nil
 	}
 	pi := tbl.GetPartitionInfo()
+	if pi != nil && pi.Type != model.PartitionTypeHash {


Please add a comment why partitions rather than HashPartition are not supported.

PS: It is actually not related to this PR, right?

Yes, it's the original code, I only move it.

Now, we only support for HashPartition.

planner/core/point_get_plan.go

zimulala · 2020-04-17T09:07:11Z

PTAL @crazycs520 @lzmhhh123 @XuHuaiyu

crazycs520 · 2020-04-17T15:12:55Z

planner/core/point_get_plan.go

+		}
+		col := model.FindColumnInfo(tbl.Cols(), colName.Name.Name.L)
+		if col == nil || // Handling the case when the column is _tidb_rowid.
+			(col.Tp == mysql.TypeString && col.Collate == charset.CollationBin) { // This type we needn't to pad `\0` in here.


Any test case for that? I don't know this is used for what.

Yes. These tests already exist. The test case for the table of create table t(a binary(2) primary key, b binary(2)); table, like select * from t where a = "a ";
@crazycs520

zimulala · 2020-04-22T09:39:24Z

PTAL
@lzmhhh123 @XuHuaiyu @crazycs520 @bb7133

sre-bot · 2020-04-23T03:37:19Z

@zimulala merge failed.

zimulala · 2020-04-23T05:24:49Z

/run-common-test
/run-sqllogic-test-1

zimulala · 2020-04-23T06:48:35Z

/merge

sre-bot · 2020-04-23T06:48:38Z

Your auto merge job has been accepted, waiting for:

16550

sre-bot · 2020-04-23T06:53:18Z

/run-all-tests

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-23T07:19:16Z

cherry pick to release-3.0 in PR #16753

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-23T07:20:31Z

cherry pick to release-3.1 in PR #16754

… overflow (pingcap#14776)

sre-bot · 2020-04-23T07:22:43Z

cherry pick to release-4.0 in PR #16755

… overflow (#14776) (#16753)

… overflow (#14776) (#16754)

wjhuang2016 · 2020-05-14T17:52:31Z

mysql> select * from t6 where a != 9223372036854775808;
ERROR 1690 (22003): constant 9223372036854775808 overflows bigint

PTAL @zimulala

zimulala · 2020-05-18T02:38:05Z

@wjhuang2016
This PR fixed the problem that PointGet returns wrong results in the case of overflow. The specific scene of the repair is stated in the description. The scene you mentioned has not been changed before or after this PR. You can create a new issue.

zimulala added 2 commits February 13, 2020 14:56

ddl, util: fix uk/pk select overflows value

7601ec3

*: remove logs

2c02cb0

zimulala requested a review from a team as a code owner February 13, 2020 07:25

ghost requested review from alivxxx and lzmhhh123 and removed request for a team February 13, 2020 07:25

zimulala added sig/execution SIG execution type/bug-fix This PR fixes a bug. labels Feb 13, 2020

lzmhhh123 reviewed Mar 17, 2020

View reviewed changes

Merge branch 'master' into zimulala/overflows

973d1a5

zimulala requested a review from a team as a code owner March 25, 2020 02:59

ghost requested review from qw4990 and wshwsh12 and removed request for a team March 25, 2020 02:59

*: pass TestDelete

328769e

zimulala force-pushed the overflows branch from 6fadb8f to 328769e Compare March 26, 2020 03:29

zimulala added 2 commits April 2, 2020 12:06

Merge branch 'master' into zimulala/overflows

04fd00e

*: tiny update

181491a

zimulala removed the request for review from alivxxx April 14, 2020 04:09

Merge branch 'master' into overflows

84ee106

Merge branch 'master' into overflows

2d1da0f

bb7133 reviewed Apr 14, 2020

View reviewed changes

crazycs520 reviewed Apr 15, 2020

View reviewed changes

planner/core/point_get_plan.go Outdated Show resolved Hide resolved

planner/core: remove useless comments

f24a565

crazycs520 reviewed Apr 17, 2020

View reviewed changes

zimulala added needs-cherry-pick-3.0 labels Apr 23, 2020

Merge branch 'master' into overflows

d610b48

wshwsh12 removed request for qw4990 and wshwsh12 April 23, 2020 06:07

Merge branch 'master' into overflows

3853b09

zimulala added the status/all-tests-passed label Apr 23, 2020

crazycs520 approved these changes Apr 23, 2020

View reviewed changes

Merge branch 'master' into overflows

6a1d208

zimulala merged commit e521ea9 into pingcap:master Apr 23, 2020

zimulala deleted the overflows branch April 23, 2020 07:18

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 23, 2020

cherry pick pingcap#14776 to release-3.0

6a1bd9f

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 23, 2020

*: fix the problem that PointGet returns wrong results in the case of overflow (#14776) #16753

Merged

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 23, 2020

cherry pick pingcap#14776 to release-3.1

e765394

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 23, 2020

*: fix the problem that PointGet returns wrong results in the case of overflow (#14776) #16754

Merged

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 23, 2020

*: fix the problem that PointGet returns wrong results in the case of…

49a31f1

… overflow (pingcap#14776)

sre-bot mentioned this pull request Apr 23, 2020

*: fix the problem that PointGet returns wrong results in the case of overflow (#14776) #16755

Merged

sre-bot added a commit that referenced this pull request Apr 30, 2020

*: fix the problem that PointGet returns wrong results in the case of…

0be031a

… overflow (#14776) (#16753)

sre-bot added a commit that referenced this pull request Apr 30, 2020

*: fix the problem that PointGet returns wrong results in the case of…

3972f45

… overflow (#14776) (#16754)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: fix the problem that PointGet returns wrong results in the case of overflow #14776

*: fix the problem that PointGet returns wrong results in the case of overflow #14776

zimulala commented Feb 13, 2020

lzmhhh123 left a comment

zimulala commented Mar 26, 2020

zimulala commented Apr 14, 2020

codecov bot commented Apr 14, 2020 •

edited

bb7133 Apr 14, 2020

zimulala Apr 15, 2020

zimulala Apr 15, 2020

zimulala commented Apr 17, 2020

crazycs520 Apr 17, 2020

zimulala Apr 20, 2020 •

edited

zimulala commented Apr 22, 2020

sre-bot commented Apr 23, 2020

zimulala commented Apr 23, 2020

zimulala commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

wjhuang2016 commented May 14, 2020

zimulala commented May 18, 2020

*: fix the problem that PointGet returns wrong results in the case of overflow #14776

*: fix the problem that PointGet returns wrong results in the case of overflow #14776

Conversation

zimulala commented Feb 13, 2020

What problem does this PR solve?

What is changed and how it works?

Check List

lzmhhh123 left a comment

Choose a reason for hiding this comment

zimulala commented Mar 26, 2020

zimulala commented Apr 14, 2020

codecov bot commented Apr 14, 2020 • edited

Codecov Report

bb7133 Apr 14, 2020

Choose a reason for hiding this comment

zimulala Apr 15, 2020

Choose a reason for hiding this comment

zimulala Apr 15, 2020

Choose a reason for hiding this comment

zimulala commented Apr 17, 2020

crazycs520 Apr 17, 2020

Choose a reason for hiding this comment

zimulala Apr 20, 2020 • edited

Choose a reason for hiding this comment

zimulala commented Apr 22, 2020

sre-bot commented Apr 23, 2020

zimulala commented Apr 23, 2020

zimulala commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

sre-bot commented Apr 23, 2020

wjhuang2016 commented May 14, 2020

zimulala commented May 18, 2020

codecov bot commented Apr 14, 2020 •

edited

zimulala Apr 20, 2020 •

edited