Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add a check to reject changing some config items during runtime #14830

Merged
merged 11 commits into from Feb 20, 2020
Merged

config: add a check to reject changing some config items during runtime #14830

merged 11 commits into from Feb 20, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 18, 2020

What problem does this PR solve?

Only a few config items can be changed during runtime now, this PR adds this check.

Check List

Tests

  • Unit test

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 19, 2020

PTAL @XuHuaiyu @wshwsh12

wshwsh12
wshwsh12 reviewed Feb 20, 2020
View reviewed changes
config/config_handler.go Outdated Show resolved Hide resolved
config/config_util_test.go Outdated Show resolved Hide resolved
@wshwsh12 wshwsh12 self-requested a review February 20, 2020 06:53
wshwsh12
wshwsh12 reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2020
XuHuaiyu
XuHuaiyu reviewed Feb 20, 2020
View reviewed changes
config/config_util.go Outdated Show resolved Hide resolved
config/config_util.go Outdated Show resolved Hide resolved
config/config_handler.go Outdated Show resolved Hide resolved
config/config_util.go Outdated Show resolved Hide resolved
config/config_util.go Outdated Show resolved Hide resolved
@qw4990
Copy link
Contributor Author

qw4990 commented Feb 20, 2020

@XuHuaiyu Thanks for your review and all comments have been addressed, PTAL.

XuHuaiyu
XuHuaiyu reviewed Feb 20, 2020
View reviewed changes
config/config_util.go Outdated Show resolved Hide resolved
config/config_util.go Outdated Show resolved Hide resolved
@qw4990
Copy link
Contributor Author

qw4990 commented Feb 20, 2020

@XuHuaiyu Thanks, all comments are addressed.

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 20, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 20, 2020

/run-all-tests

XuHuaiyu
XuHuaiyu approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 20, 2020
@qw4990 qw4990 merged commit 51a832e into pingcap:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/config status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qw4990 @XuHuaiyu @wshwsh12