Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: forbiden nested view creation (#15420) #15440

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #15420

What problem does this PR solve?

Problem Summary:
Before this commit, nested view creation is allowed in TiDB, while select on this view brings panic. Actually, nested view creation is forbidden in MySQL.

tidb> create view v as select * from t;
Query OK, 0 rows affected (0.01 sec)                                                                                                                                    tidb> create view v2 as select * from v;
Query OK, 0 rows affected (0.02 sec)
tidb> create or replace view v as select * from v2;
Query OK, 0 rows affected (0.01 sec)
tidb> select * from v;
ERROR 2013 (HY000): Lost connection to MySQL server during query

What is changed and how it works?

What's Changed:
Check the underlying views of when creating a view. And make the error message be compatible with MySQL.

tidb> create view v as select * from t;
Query OK, 0 rows affected (0.01 sec)

tidb> create view v2 as select * from v;
Query OK, 0 rows affected (0.01 sec)

tidb> create view v3 as select * from v2;
Query OK, 0 rows affected (0.01 sec)

tidb> create or replace view v as select * from v3;
ERROR 1146 (42S02): Table 'test.v' doesn't exist

How it Works:
Forbid creating view nested.

Related changes

  • Need to cherry-pick to the release branch
    release-3.0, release-3.1, release-4.0

Check List

Tests

  • Integration test

Side effects
N/A

Release note

@XuHuaiyu XuHuaiyu added type/bug-fix This PR fixes a bug. sig/planner SIG: Planner labels Mar 18, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Mar 18, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

Your auto merge job has been accepted, waiting for 15446, 15448

@SunRunAway SunRunAway added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

@XuHuaiyu merge failed.

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

@SunRunAway SunRunAway merged commit d124fe5 into pingcap:release-3.1 Mar 18, 2020
@XuHuaiyu XuHuaiyu deleted the release-3.1 branch March 18, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants