Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/design: update proposal of invisible index #15476

Merged
merged 2 commits into from Mar 19, 2020

Conversation

Deardrops
Copy link
Contributor

What problem does this PR solve?

This PR improve the proposal of invisible index.

Related to #15338

@Deardrops Deardrops changed the title docs: update proposal of invisible index docs/design: update proposal of invisible index Mar 19, 2020
@Deardrops Deardrops requested a review from bb7133 March 19, 2020 01:37
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #15476 into master will decrease coverage by 0.0151%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #15476        +/-   ##
================================================
- Coverage   80.3666%   80.3514%   -0.0152%     
================================================
  Files           502        502                
  Lines        133869     133832        -37     
================================================
- Hits         107586     107536        -50     
- Misses        17838      17844         +6     
- Partials       8445       8452         +7

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 19, 2020
@bb7133
Copy link
Member

bb7133 commented Mar 19, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 19, 2020

/run-all-tests

@sre-bot sre-bot merged commit 962105b into pingcap:master Mar 19, 2020
@bb7133 bb7133 added this to Design in Invisible Index May 29, 2020
@bb7133 bb7133 moved this from Design to Done in Invisible Index Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants