distsql: check the killed flag in the distsql package (#15592) #15616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15592 to release-3.1
What problem does this PR solve?
Problem Summary:
Fix an issue from the forum https://asktug.com/t/tidb-new-feature-max-execution-time/309
There is no index in this query and TiKV scans the whole table.
max_excution_time doesn't work because the
killed
flag is checked in eachNext
function,the code doesn't run to
Next
until it read sufficient rows in a chunk.What is changed and how it works?
Check the
killed
flag in the distsql package level, so the query could break after reading each region result. The code looks like that:https://github.com/pingcap/tidb/compare/master...tiancaiamao:coprocessor-kill?expand=1#diff-7492d01b7aac81533194642850a45b8eR206
Related changes
#14552
#12852
Check List
Tests
Release note
Improve
max-execution-time
usability by checking the interrupt signal when a new region data is read.