Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix load data deal with escape character. (#16340) #16633

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 20, 2020

cherry-pick #16340 to release-3.0


What problem does this PR solve?

According to mysql document, the escaped character is interpreted as if it was not escaped. For example, \x is just x. When TiDB load data interpreting escaped, it ignore following character, just deal with character like \t.

What is changed and how it works?

If the escaped character is interpreted as if it was not escaped, output the original character. For example:

9002 tab\ tab

will be interpreted as:

9002 tab tab

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 20, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution priority/release-blocker This PR blocks a release. Please review it ASAP. type/3.0-cherry-pick type/bug-fix This PR fixes a bug. labels Apr 20, 2020
@sre-bot sre-bot added this to the v3.0.13 milestone Apr 20, 2020
@imtbkcat
Copy link

PTAL @jackysp @cfzjywxk

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfzjywxk
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

Sorry @cfzjywxk, you don't have permission to trigger auto merge event on this branch.

@jackysp
Copy link
Member

jackysp commented Apr 22, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit b15a45f into pingcap:release-3.0 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This PR blocks a release. Please review it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bug-fix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants