Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: let select for update could be recorded for slow log and statements (#16743) #16897

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

cfzjywxk
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

cherry-pick #16743 to release-4.0

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

@cfzjywxk cfzjywxk requested a review from a team as a code owner April 28, 2020 06:12
@ghost ghost requested a review from wshwsh12 April 28, 2020 06:12
@cfzjywxk cfzjywxk changed the title server: let select for update could be recorded for slow log and statements (#16743) #16886 server: let select for update could be recorded for slow log and statements (#16743) Apr 28, 2020
@coocood
Copy link
Member

coocood commented Apr 28, 2020

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 28, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

Your auto merge job has been accepted, waiting for:

  • 16881

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 28, 2020
@sre-bot sre-bot merged commit 5165941 into pingcap:release-4.0 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants