Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make memory tracing in ProjectionExec mo ... (#17109) #17118

Merged
merged 5 commits into from
May 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 12, 2020

cherry-pick #17109 to release-4.0


What problem does this PR solve?

Issue Number: close #16697

Problem Summary: make memory tracing in ProjectionExec more accurate

What is changed and how it works?

projectionWorker may change the size of its input data chunk, but we don't trace this memory change.

Check List

Tests

  • Unit test

Release note

  • Make memory tracing in ProjectionExec more accurate

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested a review from a team as a code owner May 12, 2020 06:13
@sre-bot
Copy link
Contributor Author

sre-bot commented May 12, 2020

/run-all-tests

@ghost ghost requested a review from SunRunAway May 12, 2020 06:13
@sre-bot sre-bot requested review from wshwsh12 and XuHuaiyu May 12, 2020 06:13
@ghost ghost removed their request for review May 12, 2020 06:13
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 12, 2020
@SunRunAway
Copy link
Contributor

@qw4990 Please resolve the conflicting files.

@qw4990
Copy link
Contributor

qw4990 commented May 12, 2020

Conflicts have been resolved, PTAL @SunRunAway @wshwsh12

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels May 14, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

@sre-bot merge failed.

@qw4990
Copy link
Contributor

qw4990 commented May 14, 2020

/run-all-tests

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

@sre-bot merge failed.

@qw4990
Copy link
Contributor

qw4990 commented May 14, 2020

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented May 14, 2020

/run-integration-copr-test

@qw4990
Copy link
Contributor

qw4990 commented May 14, 2020

All checks have passed, PTAL @zz-jason

@zz-jason zz-jason changed the title executor: make memory tracing in ProjectionExec more accurate (#17109) executor: make memory tracing in ProjectionExec mo ... (#17109) May 14, 2020
@zz-jason zz-jason merged commit 1934f34 into pingcap:release-4.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression priority/release-blocker This PR blocks a release. Please review it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants