planner, infoschema : add columns about plan cache in 'performance_schema.events_statements_summary_by_digest' (#16476) #17493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema.events_statements_summary_by_digest' (pingcap#16476)
|
/run-all-tests |
sre-bot
added
sig/sql-infra
ghost
removed their request for review
djshow832
reviewed
May 29, 2020
Comment on lines
+730
to
+735
| //plan cache | ||
| if sei.PlanInCache { | ||
| ssElement.planInCache = true | ||
| ssElement.planCacheHits += 1 | ||
| } | ||
|
|
There was a problem hiding this comment.
It seems planCacheHits is enough. Why add planInCache?
There was a problem hiding this comment.
@djshow832 If users use last_plan_in_cache, there is no way to view historical plan cache hit information. Add plan_in_cache, then you can record the last plan cache hit information for each sql_digest.
zz-jason
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16476 to release-4.0
What problem does this PR solve?
Issue Number: close #16217
Problem Summary:
What is changed and how it works?
What's Changed:
plan_cache_hitsandplan_in_cache) are added toinformation_schema.statements_summaryStatementContextto record plan cache info.How it Works:
plan_in_cacheindicates whether the last statement in these statements hit plan cache.plan_cache_hitsindicates the number of times these statements hit plan cache.Related changes
pingcap/docs/pingcap/docs-cn:Tests
Side effects
Release note
select digest_text, plan_cache_hits, plan_in_cache from information_schema.statements_summary