tidb-server: make max-procs in config file take effect under cgroups #17706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17706 +/- ##
===========================================
Coverage 79.4719% 79.4719%
===========================================
Files 524 524
Lines 141436 141436
===========================================
Hits 112402 112402
Misses 19963 19963
Partials 9071 9071 |
jackysp
approved these changes
Jun 5, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
/run-cherry-picker |
|
cherry pick to release-4.0 in PR #19094 |
bobotu
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
zz-jason
pushed a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
In case the user wants to change this value under cgroups, the
maxprocs.Setwill overwrite the user's settings in the config file.What is changed and how it works?
Call
runtime.GOMAXPROCS(int(cfg.Performance.MaxProcs))aftermaxprocs.Set.Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Release note