planner,executor: fix select big number on hash partition table panic (#17881) #18186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@tiancaiamao please accept the invitation then you can push to the cherry-pick pull requests. |
|
@tiancaiamao please fix conflict |
|
/run-all-tests |
|
PTAL @imtbkcat @wjhuang2016 |
|
@wjhuang2016, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack). |
|
PTAL @imtbkcat |
|
/merge |
|
Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17881 to release-4.0
What problem does this PR solve?
Issue Number: close #17813
Problem Summary:
What is changed and how it works?
What's Changed:
Use
abs(val % pi.Num)rather thanabs(val) % pi.NumHow it Works:
abs(9223372036854775808)get a negative number that is not expected.We must make sure the return
posis a positive number:Related changes
Check List
Tests
Release note