store/tikv: limit batch split count for one request (#18191) #18694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@Connor1996 please accept the invitation then you can push to the cherry-pick pull requests. |
|
/test |
|
LGTM |
ti-srebot
added
status/LGT2
|
/merge |
|
Sorry @XuHuaiyu, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
crazycs520
approved these changes
Jul 24, 2020
ti-srebot
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18191 to release-3.0
Signed-off-by: Connor1996 zbk602423539@gmail.com
What problem does this PR solve?
Too much split may cause TiKV latency spike.
What is changed and how it works?
For one batch split request, TiKV will write all newly created regions' metadata into one write batch of RocksDB. So limit the batch split for one request and separate it into multiple requests.
Related changes
Check List
Release note