-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add execution retry count in slow log and slow_query #19487
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
1 similar comment
/run-all-tests |
@crazycs520 merge failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
Is this kind of exec_retry_count available in statement? |
No, I will add this to statement in the next PR. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #20494 |
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
The parse,compile,rewrite,optimize time are very fast, check the plan and the execution time is also very fast,
It's hard to find out the reason of this slow log, Why it spend too much time?
The reason is,
lock write conflict
, and then re-execute this statement.So this PR record the execution retry count in slow log and slow_query.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note