Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Support stddev_pop function (#19195) #19541

Merged
merged 9 commits into from
Sep 1, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 27, 2020

cherry-pick #19195 to release-4.0


What problem does this PR solve?

Issue Number: Part of #7623

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

  • Support stddev_pop function.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@Win-Man please accept the invitation then you can push to the cherry-pick pull requests.

@Win-Man
Copy link
Contributor

Win-Man commented Aug 31, 2020

/build

4 similar comments
@Win-Man
Copy link
Contributor

Win-Man commented Aug 31, 2020

/build

@Win-Man
Copy link
Contributor

Win-Man commented Aug 31, 2020

/build

@Win-Man
Copy link
Contributor

Win-Man commented Aug 31, 2020

/build

@Win-Man
Copy link
Contributor

Win-Man commented Aug 31, 2020

/build

@Win-Man
Copy link
Contributor

Win-Man commented Sep 1, 2020

/build

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19452
  • 19454
  • 19465
  • 19559
  • 19601
  • 19611
  • 18443

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit a0e28c3 into pingcap:release-4.0 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants